Fix uint ulong, add missing libs for curl, fix Travis#18
Conversation
|
BTW: The version 2.5.0 builds of the Windows DLL's already failed because of the missing libs. See the 'make' logs in the zips of https://windows.php.net/downloads/pecl/releases/solr/2.5.0/logs/ If you merge this PR and make a new release (2.5.1 ?) the Windows DLL's for Pecl should be created. |
Jan-E
changed the title
Notes: - It adds a patch file that is 99.99% php/pecl-search_engine-solr#18 (but with travis, unrelated, and config.w32, conflicting and not used by us, changes taken apart). - Note I don't know much about the Portfile syntax, so that condition was the only way I found to apply the patch only for 7.4. - With the patch applied and the extension installed, we are getting a pass running our (moodle) unit tests. So it seems to work. - Cannot say much else, :-)
Notes: - It adds a patch file that is 99.99% php/pecl-search_engine-solr#18 (but with travis, unrelated, and config.w32, conflicting and not used by us, changes taken apart). - Note I don't know much about the Portfile syntax, so that condition was the only way I found to apply the patch only for 7.4. - With the patch applied and the extension installed, we are getting a pass running our (moodle) unit tests. So it seems to work. - Cannot say much else, :-)
|
Comment on behalf of omars at php.net: thanks, merged! |
|
@0mars I will submit a new PR today to prepare for PHP8. zend_hash_sort never fails since PHP 5.5.0 and will throw an error in PHP8, so it can be changed now. See php/php-src#3936 (comment) |
|
Thanks @Jan-E appreciate your work, keep it up!! |
|
Does master compile on windows now ? I don't have a windows machine to test |
|
I just cloned the repo once again and made a new branch zend-hash-sort-never-fails. Will try it with that branch. |
4 participants
This PR fixes:
https://github.com/php/php-src/blob/PHP-7.4/UPGRADING.INTERNALS#L216
php/php-src@a1ba300#diff-4e6782d127d4f20ec4acfb42474941e5
After this PR config.w32 will work for the Windows building of PHP 7.0 up until PHP 7.4