Repository navigation
Conversation
Contributor
Author
|
The MACOS_ARM64_DEBUG_NTS build failure also happens on PHP-8.6 itself, so it isn't caused by this change. |
iliaal
approved these changes
Oct 26, 2026
iliaal
left a comment
iliaal
left a comment
Member
There was a problem hiding this comment.
Verified on PHP-8.6: opendir() and scandir() with a wrapper that unregisters itself are valgrind-clean with this, and it matches what _php_stream_open_wrapper_ex() already does.
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user wrapper's dir_opendir() unregisters the wrapper, the opener drops the last reference and frees it, then _php_stream_opendir() reads wrapper->wops->label to report the error. This copies the wrapper name before calling the opener, the same way _php_stream_open_wrapper_ex() already does for fopen().
Fixes #24707