zend_compile.c: remove unneeded const_expr_context wrapper for boolean#15925
Closed
DanielEScherzer wants to merge 1 commit into
Closed
zend_compile.c: remove unneeded const_expr_context wrapper for boolean#15925DanielEScherzer wants to merge 1 commit into
const_expr_context wrapper for boolean#15925DanielEScherzer wants to merge 1 commit into
Conversation
The struct only has a single value, whether to allow expressions with dynamic values - instead of using a struct, just pass around the boolean value.
Member
Author
Member
|
These things make it easy to add more contextual variables later on, so I'd rather not get rid of this. |
Member
|
I would agree. We generally try to avoid making changes that aren't objectively better, because that opens up the possibility for ping pong changes, based on personal preference. Thanks nonetheless! @DanielEScherzer It's nice to see a new returning contributor! Keep it up! Ping us on chat.stackoverflow.com[slash]rooms/11/php, or on Discord ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The struct only has a single value, whether to allow expressions with dynamic values - instead of using a struct, just pass around the boolean value.