GH-15976: clarify error messages for enum/trait/interface/alias names

[DanielEScherzer]

Instead of always saying that a name is reserved or deprecated and
cannot/should not be used as a class name, take the usage into account and say
the name cannot be used as an enum name, trait name, etc. In the process, for
class names add a missing "a".

Add tests for the new messages.

[Girgias]

Seems reasonable to me, maybe @TimWolla wants to have a look as IIRC they have good opinions about error messages

[Girgias]

Unrelated: love the TODO message about moving something out in 7.4. :D

[TimWolla]

No strong feelings, but this is indeed an improvement.

[DanielEScherzer]

Double quotes change is at #15990, trait test name change is at #15991

[cmb69]

@DanielEScherzer, I've just noticed that your commits are not signed. While this is, to my knowledge, not a requirement, it might still be a good idea to do it; see https://wiki.php.net/vcs/commit-signing for details.

Also, seeing the number of your contributions, consider to apply for a php.net account at https://www.php.net/git-php.php.

[DanielEScherzer]

@DanielEScherzer, I've just noticed that your commits are not signed. While this is, to my knowledge, not a requirement, it might still be a good idea to do it; see https://wiki.php.net/vcs/commit-signing for details.

It might be a good idea, but that page says as a prerequisite:

You are able to pull and push to at least one PHP repository.

which is not the case for me

Also, seeing the number of your contributions, consider to apply for a php.net account at https://www.php.net/git-php.php.

Given that I've only been contributing for less than a month, I think I'd rather get some more experience with the various undocumented conventions (or if they are documented, can you point me to them?) - e.g., I would have considered #15832 a trivial change and clear improvement, but apparently having the do {} while (0) is a best practice even when it is unneeded. Thanks for the vote of confidence though!

[iluuu1994]

It might be a good idea, but that page says as a prerequisite:

That's wrong, you don't need that to sign commits. However, it's also worth noting that most likely your commit will either be squashed/rebased by the GitHub GUI, or by the merged in the CLI, in which case your signature is irrelevant anyway.

https://github.com/php/php-src/commits/master/?author=DanielEScherzer

The reason your last commits aren't signed is because @Girgias' commits aren't signed.

/cc @cmb69

[cmb69]

Given that I've only been contributing for less than a month, I think I'd rather get some more experience with the various undocumented conventions (or if they are documented, can you point me to them?) - e.g., I would have considered #15832 a trivial change and clear improvement, but apparently having the do {} while (0) is a best practice even when it is unneeded.

The documentation about this is seriously lacking. Consider to contribute to https://github.com/php/php-src/tree/master/docs (but note that a couple of things are already documented at https://github.com/php/php-src/tree/master/docs-old, and maybe elsewhere).

The reason your last commits aren't signed is because @Girgias' commits aren't signed.

Ah, right, although some are.

[DanielEScherzer]

Given that I've only been contributing for less than a month, I think I'd rather get some more experience with the various undocumented conventions (or if they are documented, can you point me to them?) - e.g., I would have considered #15832 a trivial change and clear improvement, but apparently having the do {} while (0) is a best practice even when it is unneeded.

The documentation about this is seriously lacking. Consider to contribute to https://github.com/php/php-src/tree/master/docs (but note that a couple of things are already documented at https://github.com/php/php-src/tree/master/docs-old, and maybe elsewhere).

Its on my list, #15954

[iluuu1994]

Ah, right, although some are.

Right, those are the PRs merged through the GitHub UI:

ae4ef32

Maybe @Girgias accidentally stopped signing commits.

[Girgias]

It depends on my computer I think.

If I remember my setups correctly, I set up the signed commits on my desktop but not on my laptop :|