Skip to content

ext/curl: Deprecate the NTLM_WB constants #22691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GrahamCampbell wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ext/curl: Deprecate the NTLM_WB constants #22691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ PHP NEWS
. Fixed bug GH-22602 (gregoriantojd() and juliantojd() integer overflow with
INT_MAX year). (arshidkv12)

- Curl:
. Deprecated the CURLAUTH_NTLM_WB and CURL_VERSION_NTLM_WB constants, as
libcurl 8.8.0 removed NTLM_WB support. (Graham Campbell)

- Date:
. Update timelib to 2022.17. (Derick)
. Fixed bug GH-19803 (Parsing a string with a single white space does create
Expand Down
4 changes: 4 additions & 0 deletions UPGRADING
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,10 @@ PHP 8.6 UPGRADE NOTES
. Making __construct() and __destruct() a Generator is now deprecated.
RFC: https://wiki.php.net/rfc/deprecate-return-value-from-construct

- Curl:
. The CURLAUTH_NTLM_WB and CURL_VERSION_NTLM_WB constants are deprecated, as
libcurl 8.8.0 removed NTLM_WB support.

- GMP
. The shift (<<, >>) and exponentiation (**) operators on GMP objects now
emit a deprecation warning when converting a float right operand to int
Expand Down
2 changes: 2 additions & 0 deletions ext/curl/curl.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2390,6 +2390,7 @@
* @var int
* @cvalue CURLAUTH_NTLM_WB
*/
#[\Deprecated(since: '8.6', message: 'as libcurl 8.8.0 removed NTLM_WB support')]
const CURLAUTH_NTLM_WB = UNKNOWN;
/**
* @var int
Expand All @@ -2410,6 +2411,7 @@
* @var int
* @cvalue CURL_VERSION_NTLM_WB
*/
#[\Deprecated(since: '8.6', message: 'as libcurl 8.8.0 removed NTLM_WB support')]
const CURL_VERSION_NTLM_WB = UNKNOWN;

/* Available since 7.24.0 */
Expand Down
20 changes: 17 additions & 3 deletions ext/curl/curl_arginfo.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions ext/curl/tests/curl_ntlm_wb_deprecation.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--TEST--
CURLAUTH_NTLM_WB and CURL_VERSION_NTLM_WB constants are deprecated
--EXTENSIONS--
curl
--FILE--
<?php
var_dump(CURLAUTH_NTLM_WB);
var_dump(CURL_VERSION_NTLM_WB);
?>
--EXPECTF--
Deprecated: Constant CURLAUTH_NTLM_WB is deprecated since 8.6, as libcurl 8.8.0 removed NTLM_WB support in %s on line %d
int(%d)

Deprecated: Constant CURL_VERSION_NTLM_WB is deprecated since 8.6, as libcurl 8.8.0 removed NTLM_WB support in %s on line %d
int(%d)
Loading