ext/odbc: do not mutate the caller's DSN string#22776
Open
iliaal wants to merge 1 commit into
Open
Conversation
odbc_sqlconnect() stripped a trailing semicolon by writing a NUL into the Z_PARAM_STRING buffer, which is a zend_string. Shared variables, interned literals, and const values used as the DSN were permanently altered (strlen unchanged, last byte became NUL). Compute the base length instead and pass it to spprintf with %.*s, matching the non-mutating approach used when assembling UID/PWD into the connect string. Closes phpGH-22776
iliaal
force-pushed
the
fix/odbc-dsn-string-immutability
branch
from
8327764 to
7d70e5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
odbc_sqlconnect()stripped a trailing;by writing a NUL into the caller’s DSNzend_string. Shared variables, interned literals, andconstvalues used as the DSN were permanently altered (strlenunchanged, last byte became NUL).Compute a base length instead and pass it to
spprintfwith%.*s. Does not touch the argument buffer.ext/pdo_odbcalready copies before mutating and does not need a change.