Repository navigation
openssl: check if reneg_limit_callback is callable prior to calling - #24414
Merged
Girgias merged 2 commits intoOct 19, 2026
Merged
Conversation
Girgias
force-pushed
the
2026-10-openssl-call-user-fn-migration
branch
from
October 18, 2026 23:05
eabe45a to
0e37c11
Compare
Girgias
marked this pull request as ready for review
October 19, 2026 14:01
ndossche
approved these changes
Oct 19, 2026
ndossche
left a comment
ndossche
left a comment
Member
There was a problem hiding this comment.
Semantically there's no difference AFAICT.
But I suppose you want to get rid of call_user_function entirely at some point, hence this PR? (Sorry, my memory is fuzzy, I'm just a small language model after all)
Because if call_user_function were to stay existing in the future, then the old code is preferable because it's simpler
Member
Author
|
Yes that is the plan. There are about 10 remaining calls, some would go away with PHP 9 (e.g. assert and ext/session), some need a new API to call a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.