Repository navigation
Fix GH-24736: php_odbc_connstr_is_quoted() accepts missing closing brace - #24737
Merged
Merged
Conversation
NattyNarwhal
approved these changes
Oct 26, 2026
iliaal
approved these changes
Oct 27, 2026
TimWolla
pushed a commit
to TimWolla/php-src
that referenced
this pull request
Oct 27, 2026
* PHP-8.4: Fix phpGH-24736: php_odbc_connstr_is_quoted() accepts missing closing brace (php#24737)
TimWolla
pushed a commit
to TimWolla/php-src
that referenced
this pull request
Oct 27, 2026
* PHP-8.5: Fix phpGH-24736: php_odbc_connstr_is_quoted() accepts missing closing brace (php#24737)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loop only rejected a
}that wasn't doubled or at the end, so a value with no closing}at all (like{foo, or{foo}}where the last brace is escaped) came back as already quoted and skipped the UID/PWD quoting. Now it's only quoted if the scan actually ends on an unescaped}.Fixes #24736