Fix arginfos of required arguments for some Reflection methods#3797
Fix arginfos of required arguments for some Reflection methods#3797carusogabriel wants to merge 2 commits into
Conversation
|
This is still 👎 from me as it creates a BC break that is not fixable while supporting both PHP 7 and 8 (unless using conditional code). |
|
@Majkl578 You can, using |
|
@carusogabriel Please combine this PR and #3798. Let's directly go to the correct variadic signature instead of doing this in two steps... |
|
@nikic Okay. Gonna fix a test that's breaking there as well |
|
When merging this, please add an UPGRADING note that mentions all of the old signatures, the new signatures, and the signatures that can be used to be compatible with both. |
|
Merged via 35db1cc. Thanks everyone for the discussion. |
Reopening #3443 against master branch (
PHP 8.0now).This fixes: #74035 and #71416.
/cc @Ocramius @Majkl578