Elevate warnings to ValueError in ext/bcmath#4870
Closed
cmb69 wants to merge 2 commits into
Closed
Conversation
All of these warnings/ValueErrors are due to programming errors, i.e. calling a function with unsupported arguments. In particular, this matches the behavior of the `/` and `%` operators.
nikic
reviewed
Oct 28, 2019
nikic
approved these changes
Oct 28, 2019
nikic
left a comment
nikic
left a comment
Member
There was a problem hiding this comment.
Normally I'd say that we shouldn't do an exception conversion in this case, as it's not entirely unreasonable to just ignore division by zero errors in certain contexts ... however, as we have made an explicit decision to use DivisionByZeroError for normal divisions in https://wiki.php.net/rfc/engine_warnings, it only makes sense that the same also applies to bcmath for consistency.
Member
Author
|
Thanks! Applied as 84f2a98. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of these warnings/ValueErrors are due to programming errors, i.e.
calling a function with unsupported arguments. In particular, this
matches the behavior of the
/and%operators.