Use phpBB cookie names and respect delete cookies - #35
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
=========================================
Coverage 98.93% 98.94%
- Complexity 403 409 +6
=========================================
Files 12 12
Lines 1124 1134 +10
=========================================
+ Hits 1112 1122 +10
Misses 12 12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates Consent Manager’s cookie/storage naming and cleanup behavior to align with phpBB’s cookie prefixing and cookie deletion flows, ensuring consent state is cleared consistently when users delete board cookies.
Changes:
- Prefix consent cookie + localStorage key using phpBB’s
cookie_name, and expose cookie path/domain in the frontend payload. - Clear Consent Manager browser storage when phpBB “delete cookies” completes (AJAX and post-confirmation page flow).
- Update unit/functional/JS tests to reflect new payload fields and naming behavior.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/service/consent_manager_test.php | Updates service tests for prefixed cookie/storage names and payload cookie path/domain. |
| tests/javascript/consentmanager.test.js | Adds test coverage for AJAX delete-cookies cleanup; extends payload fixture with cookie path/domain. |
| tests/functional/frontend_test.php | Loosens storageKey assertion to account for phpBB cookie prefixing and aligns cookieName/storageKey expectations. |
| tests/event/listener_test.php | Verifies new event subscription and template flag assignment for clear-storage behavior. |
| styles/all/template/js/consentmanager.js | Uses payload cookie path/domain when setting cookies; adds AJAX delete-cookies cleanup hook. |
| styles/all/template/event/overall_header_head_append.html | Exposes delete-cookies URL to JS and clears localStorage after delete-cookies confirmation flow. |
| service/consent_manager.php | Prefixes storage/cookie names with cookie_name; includes cookie path/domain in frontend payload; reads consent cookie by computed name. |
| language/en/common.php | Updates privacy policy link text. |
| event/listener.php | Subscribes to core.ucp_delete_cookies and assigns template flag to trigger storage cleanup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.