Skip to content

Use phpBB cookie names and respect delete cookies - #35

Merged
iMattPro merged 2 commits into
phpbb-extensions:mainfrom
iMattPro:updates
Aug 19, 2026
Merged

iMattPro merged 2 commits into
phpbb-extensions:mainfrom
iMattPro:updates

Conversation

@iMattPro

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter

codecov-commenter commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.94%. Comparing base (9f7f76d) to head (a94537e).

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #35   +/-   ##
=========================================
  Coverage     98.93%   98.94%           
- Complexity      403      409    +6     
=========================================
  Files            12       12           
  Lines          1124     1134   +10     
=========================================
+ Hits           1112     1122   +10     
  Misses           12       12           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Consent Manager’s cookie/storage naming and cleanup behavior to align with phpBB’s cookie prefixing and cookie deletion flows, ensuring consent state is cleared consistently when users delete board cookies.

Changes:

  • Prefix consent cookie + localStorage key using phpBB’s cookie_name, and expose cookie path/domain in the frontend payload.
  • Clear Consent Manager browser storage when phpBB “delete cookies” completes (AJAX and post-confirmation page flow).
  • Update unit/functional/JS tests to reflect new payload fields and naming behavior.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/service/consent_manager_test.php Updates service tests for prefixed cookie/storage names and payload cookie path/domain.
tests/javascript/consentmanager.test.js Adds test coverage for AJAX delete-cookies cleanup; extends payload fixture with cookie path/domain.
tests/functional/frontend_test.php Loosens storageKey assertion to account for phpBB cookie prefixing and aligns cookieName/storageKey expectations.
tests/event/listener_test.php Verifies new event subscription and template flag assignment for clear-storage behavior.
styles/all/template/js/consentmanager.js Uses payload cookie path/domain when setting cookies; adds AJAX delete-cookies cleanup hook.
styles/all/template/event/overall_header_head_append.html Exposes delete-cookies URL to JS and clears localStorage after delete-cookies confirmation flow.
service/consent_manager.php Prefixes storage/cookie names with cookie_name; includes cookie path/domain in frontend payload; reads consent cookie by computed name.
language/en/common.php Updates privacy policy link text.
event/listener.php Subscribes to core.ucp_delete_cookies and assigns template flag to trigger storage cleanup.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread styles/all/template/js/consentmanager.js
@iMattPro
iMattPro merged commit 516217f into phpbb-extensions:main Aug 19, 2026
36 checks passed
@iMattPro
iMattPro deleted the updates branch August 19, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants