Sanitize superglobal reads in AdminScreenResolver#35
Merged
Conversation
isCurrentScreen/isCurrentAction/getCurrentScreen/getCurrentAction read $_REQUEST raw — no wp_unslash, no sanitization. Route them through a shared readRequestKey() helper using sanitize_key(wp_unslash(...)), mirroring how core treats the page query arg. Non-string values now resolve to null instead of leaking arrays into comparisons. Fixes #34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routes the four raw $_REQUEST reads through
sanitize_key(wp_unslash(...))via a shared helper; non-string values resolve to null. Package test suite green (59 tests). Fixes #34.Surfaced by Siren's WordPress.org review simulation; flagged as a sibling of a real review finding.