Derive REST permission_callback from controller middleware#38
Merged
Conversation
Every route registered with permission_callback => '__return_true',
which makes WordPress advertise all endpoints (including destructive
ones) as public and hides the real authorization from scanners and
reviewers — the most-flagged REST pattern in wp.org review.
The permission callback now runs the controller's own getMiddleware()
chain — no controller contract change. Authorization rejections
(RestException 401/403) surface as WP_Error at the permission gate, so
WordPress treats the route as protected. Non-auth middleware failures
(validation 422, existence 404) pass the gate and re-throw in the route
callback, preserving the legacy {error:{message,context}} payload shape
clients parse for rich validation detail. Per-request WeakMap
memoization guarantees the chain runs exactly once (middleware may
mutate request state). Controllers without middleware remain public,
exactly as before.
Declares php >=8.0 (WeakMap).
Fixes #31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the design from #31: the permission callback runs the same middleware chain the route uses — zero contract change. 401/403 → WP_Error at the gate; validation/existence failures keep the legacy error shape; WeakMap memoization runs the chain exactly once per request. Four new contract tests; suite 63 green. Fixes #31.