Repository navigation
Resolve the Windows PHP prerelease from windows.php.net's manifests - #6713
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| env: | ||
| MATRIX_TS: ${{ matrix.ts }} | ||
| run: bash .github/scripts/install-php86-windows.sh | ||
| PHP_PRERELEASE: ${{ toJSON(fromJSON(needs.php-windows-prereleases.outputs.prereleases)[matrix.php-version]) }} |
| env: | ||
| MATRIX_TS: ${{ matrix.ts }} | ||
| MATRIX_VS: ${{ matrix.vs }} | ||
| PHP_PRERELEASE: ${{ toJSON(fromJSON(needs.php-windows-prereleases.outputs.prereleases)[matrix.php-version]) }} |
| env: | ||
| MATRIX_TS: ${{ matrix.ts }} | ||
| run: bash .github/scripts/install-php86-windows.sh | ||
| PHP_PRERELEASE: ${{ toJSON(fromJSON(needs.php-windows-prereleases.outputs.prereleases)[matrix.php-version]) }} |
| env: | ||
| MATRIX_TS: ${{ matrix.ts }} | ||
| run: bash .github/scripts/install-php86-windows.sh | ||
| PHP_PRERELEASE: ${{ toJSON(fromJSON(needs.php-windows-prereleases.outputs.prereleases)[matrix.php-version]) }} |
On Windows, setup-php installs a nightly for an unreleased minor, and a nightly has no devel pack, so the turbo legs replace it with the official prerelease. Its version was pinned in PHP86_WINDOWS_VERSION, which went stale (8.6.0RC2 while RC3 is out), and its download was not verified. The new php-windows-prereleases job reads windows.php.net's stable and QA manifests once per run. For every minor in the workflow's matrices that has no stable Windows build, it outputs the prerelease's version and the file name and SHA-256 of each runtime and devel pack. The install and devel-pack steps use that entry and verify the checksums, and run for whichever minors it lists. Resolving once per run keeps every leg on the same build when a release candidate comes out mid-run. Once a minor has its stable release, the swap stops on its own. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017h1GfB7vfJPgwcTHD9Fth6
ondrejmirtes
force-pushed
the
resolve-php-windows-prereleases
branch
from
October 9, 2026 07:52
9a04af9 to
727637a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, setup-php installs a nightly for an unreleased minor (
Installed PHP 8.6.0-dev (1228a4c3…)). A nightly has no devel pack, so the turbo Windows legs swap in the official prerelease. Its version was hardcoded asPHP86_WINDOWS_VERSION, which went stale (8.6.0RC2while RC3 is out). The download wasn't verified either.What changes:
php-windows-prereleasesreads windows.php.net's stable and QA manifests (releases.json). For every minor in this workflow's matrices without a stable Windows build, it outputs the prerelease's version and each file's name and SHA-256: NTS and TS runtimes, and their devel packs.install-php-windows-prerelease.shanddownload-php-windows-devel.shtake that entry and check the SHA-256s.env:thatturbo-originscompares, so every core is rebuilt even though no core is compiled against 8.6.Tested locally:
8.6.0RC3.🤖 Generated with Claude Code
https://claude.ai/code/session_017h1GfB7vfJPgwcTHD9Fth6