Repository navigation
Accept all data provider arguments in OverridingMethodRuleTest::testBug3403() - #6737
Merged
Merged
Conversation
…ug3403() dataOverridingFinalMethod() yields three arguments. PHPUnit 12 rejects the data sets, and in Infection's per-mutant runs this test file makes the run end with "No tests executed!" and exit 0, so every mutant it covers is reported as escaped. Same fix as fb1506e applied to testOverridingFinalMethod(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QW8VaDtn3cMdQowPSh1xGG
VincentLanglet
approved these changes
Oct 12, 2026
Contributor
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testBug3403(int $phpVersion)usesdataOverridingFinalMethod(), which yields three arguments. PHPUnit 12 reports the data sets as having more arguments than the test method accepts.The visible effect is in mutation testing: Infection's per-mutant run for any mutant covered by this test file ends with "No tests executed!" and exit code 0, so those mutants are counted as escaped. That is what currently fails the "Mutation Testing" jobs on PRs touching rule or analyser code (e.g. #5976, #5977, #5979, #5980); reproduced locally with Infection 0.35.6, PHPUnit 12 and the CI coverage artifact, where removing this file from the generated config lets the existing tests kill the mutants.
Same fix as fb1506e applied to
testOverridingFinalMethod().🤖 Generated with Claude Code
https://claude.ai/code/session_01QW8VaDtn3cMdQowPSh1xGG