[phpstan-bot]

Summary

When PHPStan runs on PHP < 8.5 and the analysed PHP version range only maybe reaches 8.5 (e.g. "php": "^8.4" in composer.json → int<80400, 80699>), FILTER_FLAG_GLOBAL_RANGE was read as FILTER_THROW_ON_FAILURE. filter_var() lost false from its return type and comparisons against false were reported as always true. This was a regression from #6551, which moved the version check to Scope::getPhpVersion(): for a range, the check became maybe, so hasFlag() ran.

Changes

• src/Type/Php/FilterFunctionReturnTypeHelper.php: hasThrowOnFailureFlag() is now public. It returns no when the scope's PHP versions only maybe have FILTER_THROW_ON_FAILURE and the bit is ambiguous, which means the stubbed FILTER_THROW_ON_FAILURE value equals the runtime FILTER_FLAG_GLOBAL_RANGE value. If the scope is definitely PHP 8.5+ (e.g. inside if (PHP_VERSION_ID >= 80500)), the flag is still detected.
• src/Type/Php/FilterFunctionsThrowTypeExtension.php: uses the same helper instead of a bare hasFlag('FILTER_THROW_ON_FAILURE'). This fixes the sibling bug where FILTER_FLAG_GLOBAL_RANGE was treated as throwing Filter\FilterFailedException, so a catch for it was not reported as dead.
• Probed FilterVarRule ("Cannot use both FILTER_NULL_ON_FAILURE and FILTER_THROW_ON_FAILURE"). It is gated on the single configured PhpVersion, which stays below 8.5 for such ranges, so it was not affected in the reported scenario.

Root cause

PHPStan resolves internal constant values from the runtime. On PHP < 8.5, FILTER_FLAG_GLOBAL_RANGE is 0x10000000. PHP 8.5 moved it to 0x20000000 and gave 0x10000000 to FILTER_THROW_ON_FAILURE, which comes from stubs on older runtimes. A bitmask test therefore cannot tell the two flags apart on such a runtime. Before #6551, the version check for a range said "no". Afterwards it said "maybe", and the bitmask test ran anyway. Both consumers of the throw-on-failure check (the return type helper and the throw type extension) now go through one guarded method.

Test

• tests/PHPStan/Analyser/data/scope-php-version-range-return-type-extensions.php (range 7.4–8.5): filter_var / filter_input_array calls with FILTER_FLAG_GLOBAL_RANGE, including the issue's combined flags, are expected to keep false (or null with FILTER_NULL_ON_FAILURE).
• tests/PHPStan/Rules/Exceptions/data/throw-type-php-versions.php (range 8.0–8.5): catching Filter\FilterFailedException around filter_var(..., FILTER_FLAG_GLOBAL_RANGE) is reported as a dead catch.
• Both fail without the fix on a PHP 8.4 runtime and pass with it. They also pass on PHP 8.5, where the constants don't collide. The existing nsrt assertion (int for FILTER_THROW_ON_FAILURE inside PHP_VERSION_ID >= 80500) still passes.

Fixes phpstan/phpstan#15481

[staabm]

move $scope->getPhpVersion() before the loop

[phpstan-bot]

I moved the $scope->getPhpVersion() call before the loop and pushed the change as commit e6f5722f9. make tests passes (22562 tests, 106 skipped) and make phpstan reports no errors.

In FilterFunctionsThrowTypeExtension::getThrowTypeFromFunctionCall(), the PHP versions are now read once into $phpVersions at the top. The early-return check before the loop and the hasThrowOnFailureFlag() call inside it both use that variable, so getPhpVersion() is no longer called on every pass through the loop. Nothing else changed.