Repository navigation
Move exitImmediately() to ForkedChild, a shadowed class in the API - #6793
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
PHP before 8.1 reads a native never as a class name, and the downgrade has no rule for it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rector will fork its own parallel workers. A forked child has to end with
_exit(), and only the turbo extension has it, asPHPStanTurbo\Runtime::exitImmediately(). That class is not part of the API, and the phar has no stub for it.This moves
exitImmediately()toPHPStan\Turbo\ForkedChild, a shadowed class marked@api. The native class inForkedChild.cppcalls_exit()with the engine's exit status, as before. The PHP twin throws the new@apiTurboNotActiveException.ForkedChildTerminatorcalls the new class and still checksTurboExtensionEnabler::isActive()first.The class is not called
Runtime. The differential tests declare a native twin asPHPStanTurbo\plus its short name, which would collide with the bootstrap classPHPStanTurbo\Runtime. The otherRuntimemethods stay inanalysis-stub.php:TurboExtensionEnablercalls them before shadowing is active, so they cannot go through a twin.turbo-ext/tests/exit-immediately.phpnow calls the native class through the prefixed declaration and checks that the twin throws. When the native method does nothing, the test fails.exitImmediately()declaresneverin PHPDoc only. PHP before 8.1 reads a nativeneveras a class name, and the downgrade has no rule for it.🤖 Generated with Claude Code