fix: simplify footer quick links styling#265
fix: simplify footer quick links styling#265abhijeetnardele24-hash wants to merge 1 commit intophysicshub:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refines the footer “Quick Links” section styling to better match the site’s layout and theme behavior, addressing issue #263.
Changes:
- Left-aligns the “Quick Links” heading and list items.
- Removes decorative dot indicators and suppresses the global link glow in the footer.
- Replaces the “Leave Feedback” anchor click target with a semantic
<button>styled like the other links.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/(core)/styles/index.css | Updates footer quick links alignment and hover styling; removes dot-indicator styling; adds link-like button styling for feedback. |
| app/(core)/components/Footer.jsx | Removes dot markup and converts “Leave Feedback” to a real button for correct behavior/semantics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| transition: | ||
| color 0.3s, | ||
| text-shadow 0.3s; | ||
| text-shadow 0.3s, | ||
| box-shadow 0.3s; |
There was a problem hiding this comment.
box-shadow is included in the transition list and explicitly set to none on hover for footer quick links, but no footer link styles ever apply a non-none box-shadow (and the global a:hover glow is via text-shadow). Consider removing box-shadow from both the transition and hover override so the hover feedback stays focused on a simple color change (plus the necessary text-shadow: none override).
|
Thank you for this! Can you show me your solution? |
Sure, I’ve left-aligned the Quick Links section, removed the dot indicators, and simplified the hover state to just a color change. I can add a quick clip here as well if that helps. |
|
Yeah @abhijeetnardele24-hash would be awesome thanks |
|
@abhijeetnardele24-hash are you still on this? |
This tightens up the footer quick links so they feel more consistent with the rest of the layout.\n\n- left-aligns the Quick Links heading and list\n- removes the decorative dot indicators\n- keeps the links in the normal theme text color by default\n- limits hover feedback to a simple color change\n- switches the feedback entry to a real button so it behaves like the other quick actions\n\nCloses #263