Torus initial PR#1777
Conversation
|
Hmm, ok. But if you have the attitude of creating PRs without waiting for existing work to be completed first, other people will start spending time creating their own PRs and not review yours anymore. :) |
All PRs opened by other people open right now (except #1426) require action by the author, which is partly why I added the awaiting author label. |
|
@prabau I added the last sentence (This PR has low/high priority) to every of my open PRs now. The most important one is #1775. #1725 is relatively big but I think really a good addition and #1776 good to have for the reasons I pointed out there. All the trait PRs by me are really not so important. |
|
Ok. I'll start taking a look at #1775 tomorrow. |
One part of #1770. (I got two likes and no comments, so why not add now)
This PR only contains trivial traits and almost completes the space already at the same time.
Funnily enough, I believe that the torus would be indistinguishable in pibase from S168 (projective plane) if it were not for p89 (fixed point property)
I set this PR partly up with claude code (telling it the traits and tell to adopt style) and it worked decently well (I fixed various stuff later, but it still definitely saved a lot of time)
This PR has low priority! (but I am not a believer in holding up making PRs for the sake of it)