Repository navigation
Release/v1.4.3 - #160
Release/v1.4.3#160
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis release updates the project and runtime version from 1.4.2 to 1.4.3, refreshes the Poetry lockfile, and adjusts a stream implementation test to recognize another valid ordering of grouped results. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="tests/_streams/test_stream_implementation.py" line_range="200" />
<code_context>
.to_list()
self.assertIn(result, [
[(1, [pt1, pt2]), (2, [pt3, pt4])],
+ [(1, [pt1, pt2]), (2, [pt4, pt3])],
[(2, [pt3, pt4]), (1, [pt1, pt2])],
[(1, [pt2, pt1]), (2, [pt4, pt3])],
</code_context>
<issue_to_address>
**Valid parallel order fails assertion**
When parallel tasks create key 2 first, append pt4 before pt3, and append pt1 before pt2, `ParallelStream._group_to_dict` returns `[(2, [pt4, pt3]), (1, [pt1, pt2])]`, which `test_group_by`'s `assertIn` does not accept, so the test fails despite correct grouping.
Normalize group and per-key element order before asserting, or accept every valid scheduling order.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: tests/_streams/test_stream_implementation.py:200
| .to_list() | ||
| self.assertIn(result, [ | ||
| [(1, [pt1, pt2]), (2, [pt3, pt4])], | ||
| [(1, [pt1, pt2]), (2, [pt4, pt3])], |
There was a problem hiding this comment.
🟡 Medium · Valid parallel order fails assertion
When parallel tasks create key 2 first, append pt4 before pt3, and append pt1 before pt2, ParallelStream._group_to_dict returns [(2, [pt4, pt3]), (1, [pt1, pt2])], which test_group_by's assertIn does not accept, so the test fails despite correct grouping.
Normalize group and per-key element order before asserting, or accept every valid scheduling order.
Prompt for AI agents
In `tests/_streams/test_stream_implementation.py` at line 200:
**Valid parallel order fails assertion**
When parallel tasks create key 2 first, append pt4 before pt3, and append pt1 before pt2, `ParallelStream._group_to_dict` returns `[(2, [pt4, pt3]), (1, [pt1, pt2])]`, which `test_group_by`'s `assertIn` does not accept, so the test fails despite correct grouping.
Normalize group and per-key element order before asserting, or accept every valid scheduling order.


Summary by Sourcery
Prepare the project for the 1.4.3 release with refreshed dependencies and expanded stream behavior coverage.
Build:
Tests:
Chores: