Skip to content

Release/v1.4.3 - #160

Merged
garlontas merged 2 commits into
mainfrom
release/v1.4.3
Oct 19, 2026
Merged

garlontas merged 2 commits into
mainfrom
release/v1.4.3

Conversation

@garlontas

@garlontas garlontas commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Summary by Sourcery

Prepare the project for the 1.4.3 release with refreshed dependencies and expanded stream behavior coverage.

Build:

  • Update the project dependency lockfile.

Tests:

  • Expand stream implementation coverage for nondeterministic grouping order.

Chores:

  • Bump the package and runtime version to 1.4.3.

@sourcery-ai

sourcery-ai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This release updates the project and runtime version from 1.4.2 to 1.4.3, refreshes the Poetry lockfile, and adjusts a stream implementation test to recognize another valid ordering of grouped results.

File-Level Changes

Change Details Files
Bump the package and runtime versions to 1.4.3 for the release.
  • Update the Poetry project version.
  • Update the exported package version value.
pyproject.toml
pystreamapi/__init__.py
Refresh locked dependency metadata for the release.
  • Regenerate dependency lock data with substantial additions and removals.
poetry.lock
Broaden coverage for nondeterministic grouped stream output ordering.
  • Accept an additional valid ordering of grouped points in the stream implementation test.
tests/_streams/test_stream_implementation.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sonarqubecloud

Copy link
Copy Markdown

@garlontas
garlontas merged commit d5341ae into main Oct 19, 2026
8 of 13 checks passed
@garlontas
garlontas deleted the release/v1.4.3 branch October 19, 2026 19:53

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="tests/_streams/test_stream_implementation.py" line_range="200" />
<code_context>
             .to_list()
         self.assertIn(result, [
             [(1, [pt1, pt2]), (2, [pt3, pt4])],
+            [(1, [pt1, pt2]), (2, [pt4, pt3])],
             [(2, [pt3, pt4]), (1, [pt1, pt2])],
             [(1, [pt2, pt1]), (2, [pt4, pt3])],
</code_context>
<issue_to_address>
**Valid parallel order fails assertion**

When parallel tasks create key 2 first, append pt4 before pt3, and append pt1 before pt2, `ParallelStream._group_to_dict` returns `[(2, [pt4, pt3]), (1, [pt1, pt2])]`, which `test_group_by`'s `assertIn` does not accept, so the test fails despite correct grouping.

Normalize group and per-key element order before asserting, or accept every valid scheduling order.
</issue_to_address>

Sourcery assessment

Approval pending. 1 finding to address first.

Blocking findings: tests/_streams/test_stream_implementation.py:200


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

.to_list()
self.assertIn(result, [
[(1, [pt1, pt2]), (2, [pt3, pt4])],
[(1, [pt1, pt2]), (2, [pt4, pt3])],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium · Valid parallel order fails assertion

When parallel tasks create key 2 first, append pt4 before pt3, and append pt1 before pt2, ParallelStream._group_to_dict returns [(2, [pt4, pt3]), (1, [pt1, pt2])], which test_group_by's assertIn does not accept, so the test fails despite correct grouping.

Normalize group and per-key element order before asserting, or accept every valid scheduling order.

Prompt for AI agents
In `tests/_streams/test_stream_implementation.py` at line 200:

**Valid parallel order fails assertion**

When parallel tasks create key 2 first, append pt4 before pt3, and append pt1 before pt2, `ParallelStream._group_to_dict` returns `[(2, [pt4, pt3]), (1, [pt1, pt2])]`, which `test_group_by`'s `assertIn` does not accept, so the test fails despite correct grouping.

Normalize group and per-key element order before asserting, or accept every valid scheduling order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant