fix(home): precise readiness mail-warning wording (#4297 Node half)#3861
Conversation
With the admin layout banner removed on the UI side, the readiness 'mail' row is the single signal for an unconfigured mailer — its warning message now carries the consequence wording (users register without email verification) instead of relying on a separate banner. The ok-branch message and the category order are unchanged. refs pierreb-devkit/Vue#4297
|
Warning Review limit reached
More reviews will be available in 52 minutes and 18 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the admin “Readiness” mail check warning to explicitly describe the user-facing consequence when no mail provider is configured, and adds unit coverage to lock the wording in.
Changes:
- Updates the
mailreadiness warning message to:No mail provider configured — users register without email verification. - Adds unit tests covering both the
warning(no mailer) andok(mailer configured) mail readiness messages.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/home/services/home.service.js | Updates the mail readiness warning message to include the consequence when mail is not configured. |
| modules/home/tests/home.service.unit.tests.js | Adds unit tests to assert the updated warning wording and ensure the ok message remains unchanged. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3861 +/- ##
=======================================
Coverage 92.41% 92.41%
=======================================
Files 162 162
Lines 5394 5394
Branches 1736 1735 -1
=======================================
Hits 4985 4985
Misses 328 328
Partials 81 81
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Summary
Node half of #4297 (the Vue half — dropping the redundant admin mailer banner — ships in the Vue admin/account UX PR). The admin Readiness tab is now the single home for the "no mailer" signal, so its wording carries the consequence:
modules/home/services/home.service.js— the mail readiness check's warning message becomesNo mail provider configured — users register without email verification(theok-branch messageMail provider configuredis unchanged).Test plan
home.service.unit12/12, fullhomemodule 31/31 (the integration test's pinned category order['config','security','auth','mail','billing','analytics','errorTracking']is untouched). Lint clean.refs pierreb-devkit/Vue#4297