Skip to content

scaffold: add json tags to ChangelogRel (metadata.json was Go-cased) #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alexgodoroja merged 2 commits into from
Jun 24, 2026
Merged

scaffold: add json tags to ChangelogRel (metadata.json was Go-cased) #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3527ac4
scaffold: add json tags to ChangelogRel
Jun 24, 2026
64edd45
gofmt internal/scaffold/changelog_json_test.go
Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions internal/scaffold/changelog_json_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
package scaffold

import (
"encoding/json"
"strings"
"testing"
)

func TestChangelogJSONLowercase(t *testing.T) {
c := &Config{ID: "io.x.y", Namespace: "y", AppVersion: "0.1.0", Description: "d",
Listing: Listing{Changelog: []ChangelogRel{{Version: "0.1.0", Notes: []string{"first"}}}}}
b, _ := json.Marshal(BuildMetadata(c))
s := string(b)
for _, k := range []string{`"version"`, `"notes"`} {
if !strings.Contains(s, k) {
t.Errorf("metadata changelog missing lowercase key %s", k)
}
}
for _, k := range []string{`"Version"`, `"Notes"`, `"Date"`} {
if strings.Contains(s, k) {
t.Errorf("metadata changelog has Go-cased key %s", k)
}
}
}
6 changes: 3 additions & 3 deletions internal/scaffold/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@ type Vendor struct {

// ChangelogRel is one release's notes for the store page.
type ChangelogRel struct {
Version string `yaml:"version"`
Date string `yaml:"date"`
Notes []string `yaml:"notes"`
Version string `json:"version" yaml:"version"`
Date string `json:"date,omitempty" yaml:"date"`
Notes []string `json:"notes,omitempty" yaml:"notes"`
}

// Publisher carries the path to the ed25519 signing key (generated once via
Expand Down
Loading