Skip to content

ci: use native temp dir to fix macOS TempDir flake #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TeoSlayer merged 1 commit into from
Jun 24, 2026
Merged

ci: use native temp dir to fix macOS TempDir flake #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 20 additions & 15 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,22 +44,27 @@ jobs:
# -short skips 3 known-slow stress tests in pkg/daemon and
# pkg/daemon/udpio; everything else runs.
#
# Both hosted runners have started handing out a $RUNNER_TEMP
# (/Users/runner/work/_temp on macOS, /home/runner/work/_temp on
# ubuntu) whose ACLs make t.TempDir() fail with "mkdir ...:
# permission denied" — a recurring GitHub-runner issue (seen on
# #304/#306/#308 for macOS and now hitting ubuntu too). A writable
# subdir under it inherits the same restriction, so redirecting
# TMPDIR *into* $RUNNER_TEMP is not enough; it must point at a
# freshly-created dir outside that tree. Create one under /tmp
# (writable by the test process on both Linux and macOS), chmod it
# so t.TempDir()'s sub-dirs are creatable, and point $TMPDIR there
# for THIS run block so go test's os.TempDir() -> t.TempDir()
# lands somewhere writable. No job/step-level `env: TMPDIR:` is set
# anywhere in this workflow, so nothing overrides this export.
# t.TempDir() flakes with "mkdir <dir>/<TestName>/001: permission
# denied" on the hosted runners when $TMPDIR points into /tmp.
# /tmp (and /private/tmp on macOS) is world-writable with the
# sticky bit (mode 1777); the runner's extra sandbox layer
# (sandbox-exec on macOS, AppArmor on ubuntu) intermittently
# denies the nested mkdir Go does for each parallel sub-test there,
# which is why #316's `mktemp -d /tmp/...` + chmod 777 still failed
# on #302/#321/#325 (and started hitting ubuntu too). The fix is to
# keep temp OUT of the sticky /tmp tree and use a plain, per-user,
# runner-owned directory instead:
# * macOS: the OS-native DARWIN_USER_TEMP_DIR (/var/folders/.../T)
# — a per-user temp with no sticky bit and no sandbox quirk.
# * Linux: a fresh dir under the runner-owned $RUNNER_TEMP.
# No job/step-level `env: TMPDIR:` is set anywhere in this
# workflow, so nothing overrides this export.
run: |
TMPDIR="$(mktemp -d /tmp/gotmpXXXXXX 2>/dev/null || mktemp -d "${RUNNER_TEMP:-.}/gotmpXXXXXX")"
chmod 777 "$TMPDIR"
if [ "${RUNNER_OS}" = "macOS" ]; then
TMPDIR="$(getconf DARWIN_USER_TEMP_DIR)"
else
TMPDIR="$(mktemp -d "${RUNNER_TEMP:-/tmp}/gotmpXXXXXX")"
fi
export TMPDIR
echo "using TMPDIR=$TMPDIR"
go test -short -count=1 -timeout 600s ./pkg/... ./cmd/... ./internal/...
Loading