fix: mode constant, README accuracy, SOUL.md Hermes warning#23
Open
TeoSlayer wants to merge 4 commits into
Open
fix: mode constant, README accuracy, SOUL.md Hermes warning#23TeoSlayer wants to merge 4 commits into
TeoSlayer wants to merge 4 commits into
Conversation
…ndling - config.go: GetMode() now falls back to defaultMode (ModeManual) instead of always returning ModeAuto when no config exists; the constant was declared but never used as a fallback. - README.md: replace non-existent Reconcile() in usage example with the real public API: Run, Tick, and ForceTick. - skillinject.go: add slog.Warn at SOUL.md write path noting that gateway-mode Hermes ignores the file (issue #26596). - manifest.go: add TODO comments above DefaultManifestURL and DefaultRepoBaseURL pointing to the future pilot-protocol/pilot-skills repo (values unchanged — repo does not exist yet). - plugin_allowlist.go: classifyPluginAllowList now distinguishes os.IsNotExist (StateDrifted — create the file) from permission-denied and other I/O errors (StateIdentical — skip merge, don't overwrite an unreadable config). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
CI is failing (test), and the mode-constant change is flagged as silently disabling the live ticker. Recommendation: confirm the ticker stays enabled (or gate the new behaviour behind an explicit flag) and get the test green before merging. |
Revert two backward-incompatible behaviour changes that broke CI: - config.go: GetMode again defaults to ModeAuto when no skill_inject flag is present (or the config is unreadable/unparseable). The previous change to defaultMode (ModeManual) silently disabled the 15-minute reconcile ticker for every existing install with no flag set, since Run() returns early for manual/disabled mode. New installs still get manual mode via the daemon's explicit SetMode startup path. Fixes TestGetMode_EmptyDefaultsAuto. - plugin_allowlist.go: classifyPluginAllowList returns StateDrifted for any non-IsNotExist read error (permission denied, path is a directory) instead of StateIdentical. StateDrifted routes through mergePluginAllowList, which re-reads and surfaces the failure as an explicit ActionError; StateIdentical silently swallowed it as a no-op. mergePluginAllowList never overwrites an unreadable file, so the config is not at risk. Fixes TestClassifyPluginAllowList_PathIsDirectory.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetMode()always returnedModeAutoas a fallback, makingdefaultMode = ModeManuala dead constant. Fixed all three fallback returns to usedefaultMode.Reconcile()function that does not exist. Updated to show the real public API:Run,Tick, andForceTick.slog.Warnat the SOUL.md heartbeat write path calling out that gateway-mode Hermes ignores this file (issue #26596), so the write is a no-op for gateway users.// TODO: update to pilot-protocol/pilot-skills once that repo is transferred from TeoSlayer.above both URL constants. Values are unchanged (repo returns 404).classifyPluginAllowListconflated allos.ReadFileerrors intoStateDrifted. Nowos.IsNotExist→StateDrifted(create the file); permission-denied / other I/O errors →StateIdentical(skip merge, do not overwrite an unreadable config).Test plan
GOWORK=off go build ./...passes (verified locally)GetModeunit test: confirm that a missing config file returnsModeManual, notModeAutoclassifyPluginAllowListtest: confirm permission-denied error returnsStateIdenticalmain.goalongside the package🤖 Generated with Claude Code