tidb-lightning: recommend matching TiDB Lightning and TiDB versions - #21945
Conversation
ti-chi-bot
Bot
added
missing-translation-status
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthrough文档统一建议使用与目标 TiDB 集群版本匹配的 TiDB Lightning。安装、启动、导入、版本要求和故障排查说明均已更新。 ChangesTiDB Lightning 版本指导
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: pingcap/docs-cn/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 9dd8680f-6207-4908-9a2c-0a6d529dd8e1
📒 Files selected for processing (5)
get-started-with-tidb-lightning.mdtidb-lightning/deploy-tidb-lightning.mdtidb-lightning/tidb-lightning-faq.mdtidb-lightning/troubleshoot-tidb-lightning.mdtidb-troubleshooting-map.md
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
[LGTM Timeline notifier]Timeline:
|
qiancai
added
the
needs-cherry-pick-release-8.5
ti-chi-bot
Bot
added
size/M
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to GitHub limitations.
🟠 Major · 将 schema 复制示例改为版本限定命令。 · tidb-lightning-faq.md:222
tidb-lightning/tidb-lightning-faq.md:222
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win将 schema 复制示例改为版本限定命令。
本 PR 已在重启示例中要求保留原任务版本，但该示例仍未指定 TiDB Lightning 版本。用户无法确认该命令使用的版本是否与目标 TiDB 集群匹配。请同步使用版本限定形式。
可直接提交的修改
tiup tidb-lightning:<version> -config /tmp/tidb-lightning.toml
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: pingcap/docs-cn/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 7369b00b-65f4-43f4-a7d1-0c52a111abe5
📒 Files selected for processing (7)
get-started-with-tidb-lightning.mdmigrate-from-sql-files-to-tidb.mdmigrate-large-mysql-to-tidb.mdtidb-lightning/deploy-tidb-lightning.mdtidb-lightning/tidb-lightning-faq.mdtidb-lightning/troubleshoot-tidb-lightning.mdtidb-troubleshooting-map.md
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.
|
@qiancai: Your lgtm message is repeated, so it is ignored. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
qiancai
added
translation/done
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
3 participants
What is changed, added, or deleted? (Required)
Recommend using the same version of TiDB Lightning as the target TiDB cluster consistently across the deployment guide, FAQ, quick start, and troubleshooting documentation.
This is a documentation guidance correction, not a product behavior change.
Validation:
git diff --checkand the repository's./scripts/markdownlintpassed for all changed Markdown files. The version-selection FAQ heading was changed; searches in both repositories found no references to its old anchor. The new Step 3 links were checked against the installation headings. No page aliases were changed. TiUP installation and version-pinned execution were also smoke-tested with Lightning v8.5.0; no data import was performed.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit