Skip to content

ci: remove ZH dispatch from JA translation cron#22803

Open
qiancai wants to merge 2 commits intopingcap:masterfrom
qiancai:remove-zh-dispatch-from-ja-cron
Open

ci: remove ZH dispatch from JA translation cron#22803
qiancai wants to merge 2 commits intopingcap:masterfrom
qiancai:remove-zh-dispatch-from-ja-cron

Conversation

@qiancai
Copy link
Copy Markdown
Collaborator

@qiancai qiancai commented Apr 25, 2026

What is changed, added or deleted? (Required)

Purpose:

This avoids duplicate ZH translation runs because translation-zh.yaml already has its own scheduled trigger.

Changes:

  • Remove the dispatch-translation-zh job from translation-cron.yml so the JA translation cron no longer dispatches the ZH translation workflow.
  • Rename the workflow to Translation Cron JA and clarify the JA-related schedule and matrix comments.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from: N/A
  • Other reference link(s): translation-zh.yaml already schedules ZH translation directly.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Validation

  • git diff --check -- .github/workflows/translation-cron.yml
  • ruby -e 'require "yaml"; YAML.load_file(".github/workflows/translation-cron.yml"); puts "YAML ok"'

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 25, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 25, 2026
@qiancai qiancai marked this pull request as ready for review April 25, 2026 01:19
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2026
@qiancai qiancai self-assigned this Apr 25, 2026
@qiancai qiancai requested a review from shhdgit April 25, 2026 01:20
@qiancai qiancai added the translation/no-need No need to translate this PR. label Apr 25, 2026
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Apr 25, 2026
Comment thread .github/workflows/translation-cron.yml Outdated
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 25, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qiancai. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant