Skip to content

releases: fix the invisible index testing steps in the v8.0.0 release notes - #24195

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:release-8.5from
yahonda:fix-invisible-index-wording-v800
Oct 8, 2026
Merged

ti-chi-bot[bot] merged 1 commit into
pingcap:release-8.5from
yahonda:fix-invisible-index-wording-v800

Conversation

@yahonda

@yahonda yahonda commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

In the v8.0.0 release notes, the tidb_opt_use_invisible_indexes feature description says:

With this feature, you can create a new index and test its performance by making the index visible first, and then modifying the system variable in the current session for testing without affecting other sessions.

"Making the index visible first" contradicts the feature. A visible index can be selected by the optimizer in every session, so the test would affect other sessions. tidb_opt_use_invisible_indexes exists so that an invisible index can be tested in the current session only:

  • The system variables table in the same file says the variable "controls whether the optimizer can select invisible indexes for query optimization in the current session".
  • The Chinese source (docs-cn, releases/release-8.0.0.md) says 「可以先将索引创建为不可见索引,然后通过修改该系统变量在当前会话中测试新索引的性能,而不影响其他会话」, that is, "first create the index as an invisible index, and then test the new index's performance in the current session by modifying the system variable, without affecting other sessions".

This PR changes the sentence to "you can create a new index as an invisible index first, and then test its performance by modifying the system variable in the current session without affecting other sessions."

This was found while reviewing the Japanese translation (#24152), which mirrors the EN text. This PR targets release-8.5 so that the weekly EN→JA sync carries the fix to the Japanese docs.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 13 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: pingcap/docs/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: c5c83b57-66c1-454c-9663-10d16e7a4761
📥 Commits

Reviewing files that changed from the base of the PR and between 49ed15d and 95cce07.

📒 Files selected for processing (1)
  • releases/release-8.0.0.md
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 6, 2026
… notes

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@yahonda
yahonda force-pushed the fix-invisible-index-wording-v800 branch from fb6342e to 95cce07 Compare October 6, 2026 06:41
@yahonda
yahonda changed the base branch from master to release-8.5 October 6, 2026 06:41
@qiancai qiancai self-assigned this Oct 8, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Oct 8, 2026
@qiancai

qiancai commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Marking as translation/no-need: the Chinese translation already describes the corrected workflow on the release-8.5 branch — "可以先将索引创建为不可见索引,然后通过修改该系统变量在当前会话中测试新索引的性能" (docs-cn releases/release-8.0.0.md:198), so it never had the confused wording this PR fixes.

@qiancai qiancai added the lgtm label Oct 8, 2026
@ti-chi-bot

ti-chi-bot Bot commented Oct 8, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Oct 8, 2026
@qiancai qiancai added needs-cherry-pick-master Should cherry pick this PR to master branch. and removed translation/no-need No need to translate this PR. labels Oct 8, 2026
@ti-chi-bot ti-chi-bot Bot added the missing-translation-status This PR does not have translation status info. label Oct 8, 2026
@qiancai qiancai added the translation/doing This PR's assignee is translating this PR. label Oct 8, 2026
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Oct 8, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed translation/doing This PR's assignee is translating this PR. labels Oct 8, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit 58e92f9 into pingcap:release-8.5 Oct 8, 2026
11 of 12 checks passed
@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch master: #24254.

@yahonda
yahonda deleted the fix-invisible-index-wording-v800 branch October 9, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-master Should cherry pick this PR to master branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants