Skip to content

releases: fix the validate_password.enable links in the v6.5.0 release notes - #24197

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:release-8.5from
yahonda:fix-validate-password-enable-links-v650
Oct 8, 2026
Merged

ti-chi-bot[bot] merged 2 commits into
pingcap:release-8.5from
yahonda:fix-validate-password-enable-links-v650

Conversation

@yahonda

@yahonda yahonda commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

In the v6.5.0 release notes, the system variables table links validate_password.enable to #password_reuse_interval-new-in-v650 in three rows (validate_password.number_count, validate_password.policy, and validate_password.special_char_count). That anchor belongs to a different variable, so readers land on the password_reuse_interval section. The other five links to validate_password.enable in the same table already use #validate_passwordenable-new-in-v650. This PR changes the three links to that anchor.

This was found while reviewing the Japanese translation (#24158), which mirrors the EN text. This PR targets release-8.5 so that the weekly EN→JA sync carries the fix to the Japanese docs.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Corrected the links in password-policy setting descriptions so they point to the relevant enablement setting.

…e notes

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: pingcap/docs/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 6424b446-a11d-4c70-859f-f5dc87fdb619
📥 Commits

Reviewing files that changed from the base of the PR and between 49ed15d and 1741589.

📒 Files selected for processing (2)
  • releases/release-6.5.0.md
  • system-variables.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The descriptions for validate_password.number_count, validate_password.policy, and validate_password.special_char_count now link their enablement conditions to validate_password.enable in the system-variable reference and 6.5.0 release notes.

Changes

Password validation documentation

Layer / File(s) Summary
Correct variable enablement links
system-variables.md, releases/release-6.5.0.md
Updated the three variable descriptions to reference validate_password.enable. Policy requirements, thresholds, and defaults remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: qiancai

Merge Risk: ⚪ Minimal · up to 17415

The documentation now points readers to the password-validation setting that enables these checks, without changing policy behavior. No merge-blocking risk is evident.

Architecture Summary

Architecture risk: 🔵 Low · up to 17415

The change affects 2 systems.

Changed systems: releases, system-variables.md

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — releases (service) was modified; 1 changed file maps to changed impact.
  • observed — system-variables.md (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in releases/release-6.5.0.md: Corrected the three password-variable descriptions so their activation conditions reference validate_password.enable, replacing the incorrect password_reuse_interval references. The documented policy thresholds and defaults remain unchanged.
  • observed — Modified behavior in system-variables.md: Updated the prerequisite link for the validate_password.number_count check from password_reuse_interval to validate_password.enable; the accompanying policy requirement is unchanged.
  • observed — Modified behavior in system-variables.md: Updated the validate_password.policy prerequisite link from password_reuse_interval to validate_password.enable.
  • observed — Modified behavior in system-variables.md: Updated the prerequisite link for the validate_password.special_char_count check from password_reuse_interval to validate_password.enable; the policy requirement is unchanged.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: fixing the validate_password.enable links in the v6.5.0 release notes.
Description check ✅ Passed The description explains the incorrect links, identifies the three affected variables, states the corrected anchor, explains the v8.5 target, and includes the required version, AI involvement, and cha…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 6, 2026
@qiancai qiancai self-assigned this Oct 8, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Oct 8, 2026
@qiancai

qiancai commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Marking as translation/no-need: the Chinese translation on the release-8.5 branch already uses the correct #validate_passwordenable-从-v650-版本开始引入 anchors in all three rows (docs-cn releases/release-6.5.0.md:348-350) and never had the wrong password_reuse_interval link target.

@ti-chi-bot ti-chi-bot Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 8, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 8, 2026
@ti-chi-bot

ti-chi-bot Bot commented Oct 8, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-10-08 09:33:08.617309628 +0000 UTC m=+291598.364540477: ☑️ agreed by qiancai.

@qiancai qiancai added the lgtm label Oct 8, 2026
@ti-chi-bot

ti-chi-bot Bot commented Oct 8, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Oct 8, 2026
@qiancai qiancai added needs-cherry-pick-master Should cherry pick this PR to master branch. and removed translation/no-need No need to translate this PR. labels Oct 8, 2026
@ti-chi-bot ti-chi-bot Bot added the missing-translation-status This PR does not have translation status info. label Oct 8, 2026
@qiancai qiancai added the translation/doing This PR's assignee is translating this PR. label Oct 8, 2026
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Oct 8, 2026
@qiancai qiancai removed the translation/doing This PR's assignee is translating this PR. label Oct 8, 2026
@ti-chi-bot ti-chi-bot Bot added the missing-translation-status This PR does not have translation status info. label Oct 8, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Oct 8, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit e8298fb into pingcap:release-8.5 Oct 8, 2026
12 checks passed
@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch master: #24255.

@yahonda
yahonda deleted the fix-validate-password-enable-links-v650 branch October 9, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-master Should cherry pick this PR to master branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants