Repository navigation
releases: fix the validate_password.enable links in the v6.5.0 release notes - #24197
Conversation
…e notes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe descriptions for ChangesPassword validation documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The documentation now points readers to the password-validation setting that enables these checks, without changing policy behavior. No merge-blocking risk is evident. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Marking as |
…date_password variable descriptions
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
What is changed, added or deleted? (Required)
In the v6.5.0 release notes, the system variables table links
validate_password.enableto#password_reuse_interval-new-in-v650in three rows (validate_password.number_count,validate_password.policy, andvalidate_password.special_char_count). That anchor belongs to a different variable, so readers land on thepassword_reuse_intervalsection. The other five links tovalidate_password.enablein the same table already use#validate_passwordenable-new-in-v650. This PR changes the three links to that anchor.This was found while reviewing the Japanese translation (#24158), which mirrors the EN text. This PR targets
release-8.5so that the weekly EN→JA sync carries the fix to the Japanese docs.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
🤖 Generated with Claude Code
Summary by CodeRabbit