Skip to content

fix(desktop): filter out stale custom models in settings panel#2385

Closed
dwoodwardgb wants to merge 1 commit intopingdotgg:mainfrom
dwoodwardgb:t3code/stale-custom-models-list-settings-panel-fix
Closed

fix(desktop): filter out stale custom models in settings panel#2385
dwoodwardgb wants to merge 1 commit intopingdotgg:mainfrom
dwoodwardgb:t3code/stale-custom-models-list-settings-panel-fix

Conversation

@dwoodwardgb
Copy link
Copy Markdown

@dwoodwardgb dwoodwardgb commented Apr 28, 2026

What Changed

When rendering the SettingsPanel, filter out custom models in the liveProvider that have been deleted from providerConfig.

Why

When a custom model is deleted from a live provider, the list is stale (not 100% sure why, it might have to do with the delete not being part of an optimistic update). In any case, providerConfig is always up to date so using it as the source of truth for custom model list state fixes the issue.

Before

t3codebefore.mov

After

t3codeafter.mov

UI Changes

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Low risk UI-only change that filters provider model lists to avoid displaying stale custom entries; no persistence, auth, or backend behavior is modified.

Overview
Prevents deleted custom models from lingering in the Providers settings UI by filtering liveProvider.models to only include custom entries still present in providerConfig.customModels.

If no live models are available, the panel still falls back to building the model list from providerConfig.customModels as before.

Reviewed by Cursor Bugbot for commit 55b8617. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Filter stale custom models from provider cards in GeneralSettingsPanel

When building providerCards, custom models from liveProvider.models are now filtered to only include models whose slug exists in providerConfig.customModels, preventing stale entries from appearing in the settings panel. The fallback that builds models directly from providerConfig.customModels is unchanged.

Macroscope summarized 55b8617.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f212fa24-f57e-4ff6-9658-8ab9d482abd1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 28, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented Apr 28, 2026

Approvability

Verdict: Approved

S im ple UI fix that filters stale custom models from the settings panel display. The change is isolated to display logic with no backend or data impact.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants