fix(desktop): keep windows if update install fails

[Adolanium]

What Changed

Desktop update install no longer destroys every window before quitAndInstall.

Backends still stop first, so WSL children get SIGTERM. quitAndInstall runs next. Windows close only after that starts. If install fails, the error path still clears quitting and records the failure, and the user still has a window.

Why

A failed quitAndInstall left no window and no path to open one. Tests covered backend-stop failure before destroy. They did not cover this path.

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes (N/A)
• I included a video for animation/interaction changes (N/A)

---

Note

Medium Risk
Changes shutdown ordering and failure recovery for a user-facing update path; incorrect ordering could still strand backends or leave windows open in edge cases.

Overview
Desktop update install no longer calls destroyAll before quitAndInstall. Backends still stop first (unchanged), then the updater starts install; windows close only after that step begins so a failed install leaves the UI usable.

When quitAndInstall or an unexpected install error occurs after backends were stopped, the flow now restarts pool instances (along with existing reset of quitting/install state and install error reporting). Tests record install ordering via installSteps and assert success order quitAndInstall → destroyAll, and failure order quitAndInstall → startBackend with quitting cleared and no window teardown.

^{Reviewed by Cursor Bugbot for commit 4b33ef8. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Keep desktop windows if quitAndInstall fails during update install

• Reorders the install flow in make so electronWindow.destroyAll runs only after quitAndInstall starts, not before
• On ElectronUpdaterQuitAndInstallError or unexpected error, stopped backends are restarted via a captured restartStoppedBackends effect instead of leaving the app in a stopped state
• Adds tests in DesktopUpdates.test.ts asserting install step ordering and that windows are kept on failure
• Risk: backend instances are now captured before stopping and restarted concurrently on failure; if a backend cannot restart, the app may be left without a running backend despite windows remaining open

^{Macroscope summarized 4b33ef8.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8a1d9051-eb13-497f-a04d-034f27f9c8fa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 7f40bda. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved at 4b33ef8

Macroscope's review found this PR approvable — This is a small, focused desktop update failure-recovery fix. It preserves the existing shutdown flow on successful installs, keeps windows available when installation fails, restarts stopped backends, and includes regression coverage for both behaviors.

^{You can add or adjust custom eligibility rules. Learn more.}