Skip to content

fix(web): support fuzzy project search #8434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidhu2000 wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −5
Open

fix(web): support fuzzy project search #8434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7be7d43
fix(web): support fuzzy project search
davidhu2000 Aug 27, 2026
d266054
fix(web): preserve cross-field palette search
davidhu2000 Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/web/src/components/CommandPalette.logic.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ describe("buildThreadActionItems", () => {
]);
});

it("preserves thread project-name matches when there is no stronger title match", () => {
it("preserves queries spanning thread and project search terms", () => {
const group: CommandPaletteGroup = {
value: "threads-search",
label: "Threads",
Expand All @@ -262,7 +262,7 @@ describe("buildThreadActionItems", () => {

const groups = filterCommandPaletteGroups({
activeGroups: [group],
query: "project",
query: "spacing project",
isInSubmenu: false,
projectSearchItems: [],
threadSearchItems: [],
Expand Down
11 changes: 8 additions & 3 deletions apps/web/src/components/CommandPalette.logic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
} from "@t3tools/contracts";
import { filterFilesystemBrowseEntries } from "@t3tools/client-runtime/state/filesystem";
import type { SidebarThreadSortOrder } from "@t3tools/contracts/settings";
import { scoreSubsequenceMatch } from "@t3tools/shared/searchRanking";
import * as Arr from "effect/Array";
import * as Result from "effect/Result";
import { type ReactNode } from "react";
Expand Down Expand Up @@ -257,7 +258,10 @@ export function buildThreadActionItems<TThread extends BuildThreadActionItemsThr

function rankSearchFieldMatch(field: string, normalizedQuery: string): number {
const normalizedField = normalizeSearchText(field);
if (normalizedField.length === 0 || !normalizedField.includes(normalizedQuery)) {
if (
normalizedField.length === 0 ||
scoreSubsequenceMatch(normalizedField, normalizedQuery) === null
) {
return Number.NEGATIVE_INFINITY;
}
if (normalizedField === normalizedQuery) {
Expand Down Expand Up @@ -333,15 +337,16 @@ export function filterCommandPaletteGroups(input: {

return searchableGroups.flatMap((group) => {
const items = Arr.filterMap(group.items, (item, index) => {
const rank = rankCommandPaletteItemMatch(item, normalizedQuery);
const haystack = normalizeSearchText(item.searchTerms.join(" "));
if (!haystack.includes(normalizedQuery)) {
if (rank === 0 && !haystack.includes(normalizedQuery)) {
return Result.failVoid;
}
Comment thread
macroscopeapp[bot] marked this conversation as resolved.

return Result.succeed({
item,
index,
rank: rankCommandPaletteItemMatch(item, normalizedQuery),
rank,
});
})
.toSorted((left, right) => right.rank - left.rank || left.index - right.index)
Expand Down
Loading