Skip to content

fix(web): show the configured stash shortcut - #8437

Open
UtkarshUsername wants to merge 1 commit into
pingdotgg:mainfrom
UtkarshUsername:fix/stash-shortcut-empty-state
Open

fix(web): show the configured stash shortcut#8437
UtkarshUsername wants to merge 1 commit into
pingdotgg:mainfrom
UtkarshUsername:fix/stash-shortcut-empty-state

Conversation

@UtkarshUsername

@UtkarshUsername UtkarshUsername commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Fixes #8369

What Changed

The empty stash state now displays the effective configured composer.stash shortcut instead of hardcoding ⌘S. The shortcut label is platform-aware and custom-keybinding aware. If stash is unbound, the empty state does not advertise a shortcut.

Why

The stash action already resolves the active keybinding, but the empty-state copy always showed ⌘S, which was incorrect on Windows/Linux and after customizing or removing the binding. Passing the resolved display label from ChatComposer keeps the UI aligned with the behavior.

UI Changes

Before:
image

After:
image

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes

Note

Low Risk
Copy-only UI change in the composer stash empty state with no auth, data, or behavior changes beyond displayed shortcut text.

Overview
The empty stash drawer no longer hardcodes ⌘S. ChatComposer now passes the resolved composer.stash display label via shortcutLabelForCommand, matching platform and custom keybindings.

ComposerStashMenu takes a new stashShortcutLabel prop (string | null). When set, the empty state adds “Press {label} with a prompt…”; when stash is unbound, it only shows “Nothing stashed yet.” Tests cover both cases.

Reviewed by Cursor Bugbot for commit d0709a7. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Show configured stash shortcut in ComposerStashMenu

Passes a dynamic shortcut label for the composer.stash command from ChatComposer.tsx into ComposerStashMenu.tsx. The empty-state helper text now appends 'Press {stashShortcutLabel} ...' only when a label is provided, and omits shortcut guidance when the command is unbound. Tests in ComposerStashMenu.test.tsx cover both the bound and null-label cases.

Macroscope summarized d0709a7.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6ed094f9-86ff-4388-b9a0-13f2da788973

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Aug 27, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at d0709a7

Macroscope's review found this PR approvable — This is a small, focused UI fix that replaces a hardcoded stash shortcut with the effective configured binding and handles unbound shortcuts cleanly. Existing stash behavior is unchanged, and focused tests cover both display cases.

You can add or adjust custom eligibility rules. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: stash displays the wrong hotkey on windows

1 participant