Skip to content

fix(codex): avoid rescanning fragmented jsonl frames - #8439

Open
tarik02 wants to merge 4 commits into
pingdotgg:mainfrom
tarik02:fix/linear-codex-jsonl-framing
Open

fix(codex): avoid rescanning fragmented jsonl frames#8439
tarik02 wants to merge 4 commits into
pingdotgg:mainfrom
tarik02:fix/linear-codex-jsonl-framing

Conversation

@tarik02

@tarik02 tarik02 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Replaced the manual buffered JSONL parser with Effect's Stream.splitLines.

Added regression coverage for messages fragmented across stdio chunks and multiple messages arriving in one chunk.

Why

The previous reader concatenated each chunk with the pending remainder and split the entire accumulated string again. Large fragmented Codex messages repeatedly scanned a growing buffer, delaying output processing.

Stream.splitLines handles chunk boundaries and final unterminated lines without custom framing state.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • No UI changes

Model: GPT-5.6-sol. Harness: T3 Code.


Note

Medium Risk
Changes JSONL framing and EOF behavior on the Codex app-server transport; incorrect line splitting could drop or mis-parse messages, though the change aligns with a standard stream primitive.

Overview
Replaces the custom stdio JSONL reader in makeCodexAppServerPatchedProtocol with Effect’s Stream.splitLines, removing the remainder ref and per-chunk re-split of the full buffer.

Incoming stdin is now decodeTextsplitLinesrunForEach(handleLine), so line boundaries are handled incrementally instead of repeatedly scanning a growing concatenated string (which delayed processing of large fragmented Codex messages). Stream-end handling is simplified: on successful stdin completion it goes straight to handleTermination with CodexAppServerInputStreamEndedError (or terminationError), without a final flush of a leftover partial line.

Reviewed by Cursor Bugbot for commit 8c1db60. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Avoid rescanning fragmented JSONL frames in makeCodexAppServerPatchedProtocol

Replaces the manual chunk-accumulation and Ref-based remainder buffer in protocol.ts with Stream.splitLines, then runs handleLine directly on each emitted line. This removes per-chunk rescanning of buffered data.

  • Behavioral Change: explicit trailing '\r' stripping is dropped (delegated to Stream.splitLines semantics), and on successful stdin completion the pipeline no longer flushes a stored remainder before invoking termination handling.

Macroscope summarized 8c1db60.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1ee8ffd5-2d5b-48f9-ab86-c6213c0d660a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Aug 27, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8c1db600ee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +355 to +356
Stream.splitLines,
Stream.runForEach(handleLine),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add focused coverage for fragmented JSONL frames

This replaces the JSONL framing state, but the commit adds no test that splits one JSON object across stdin chunks or delivers multiple frames in one chunk; the existing protocol tests only enqueue complete newline-terminated frames. Those boundaries are precisely the behavior being changed, so a buffering or final-frame-flushing regression could strand pending requests without CI detecting it. Add a focused protocol test covering fragmented, coalesced, and unterminated-at-EOF input.

AGENTS.md reference: AGENTS.md:L108-L108

Useful? React with 👍 / 👎.

@macroscopeapp

macroscopeapp Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 8c1db60

Macroscope's review found this PR approvable — This is a small, self-contained Codex transport fix that replaces repeated JSONL buffer rescanning with Effect's standard line splitter while preserving fragmented-frame and EOF handling. It changes only the incoming framing implementation and introduces no schema, security, billing, infrastructure, or cross-component behavior.

You can add or adjust custom eligibility rules. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant