Repository navigation
fix: retain ending streams until worker exit - #247
Merged
Merged
Conversation
mcollina
force-pushed
the
fix/retain-ending-stream
branch
from
September 2, 2026 10:04
c91f910 to
48ecd88
Compare
jsumners
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
end()startsWeakRefwhenREADYraces withend()--expose-gcand add an inline GC regression test, skipped when GC is unavailableThe worker normally switches to a weak stream reference after startup so abandoned streams can be collected. During
end(), however, stream event listeners may be the only remaining references. Because those listeners only form a self-cycle, GC can collect the stream, terminate its worker through the finalization registry, and preventclosefrom being emitted. This is the timeout seen on Windows/Node 26 in #246 and onmain.Testing
npm test