feat: add collision behavior support for Advanced Markers - #143
Open
lorenc-tomasz wants to merge 5 commits into
Open
lorenc-tomasz wants to merge 5 commits into
lorenc-tomasz wants to merge 5 commits into
Conversation
lorenc-tomasz
force-pushed
the
feat/advanced-markers
branch
from
August 30, 2026 10:56
c98ecde to
b7163d3
Compare
lorenc-tomasz
force-pushed
the
feat/advanced-markers
branch
2 times, most recently
from
August 30, 2026 16:20
89fabf9 to
2c15bd2
Compare
lorenc-tomasz
force-pushed
the
feat/advanced-markers
branch
from
August 30, 2026 17:32
2c15bd2 to
6da5551
Compare
lorenc-tomasz
marked this pull request as ready for review
August 31, 2026 06:22
Collaborator
Author
|
Hi, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Please ensure this PR targets the
devbranch and follows the project conventions.CI already runs linting, formatting, and build checks automatically.
Before submitting
devbranch (notmain)Summary
Adds Map ID plumbing and collision behavior support for Advanced Markers on Android and iOS while preserving the existing SVG-based marker API.
initialProps.mapIdconfiguration.RNMarker.advancedconfiguration.RNMarker.advancedOptionsconfiguration object.advancedOptions.collisionBehavior.requiredas the default collision behavior.INVALID_ARGUMENTmap error when an Advanced Marker is requested without a map ID.INVALID_ARGUMENTmap error whenadvancedOptionsis provided withoutadvanced: true.onMapCapabilitiesChangecallback for runtime capability updates.The existing
iconSvgpipeline is reused. Native pin customization is not included.Type of change
Scope
Related
N/A
Additional notes
mapIdremains optional for regular maps and standard markers.A map ID is required when
marker.advancedistrue. Whenadvancedisfalseor omitted, the existing standard marker implementation is used.Collision behavior can be configured through: