fix(web): replace .map() with .forEach() in formalizePoliciesList - #7149
Open
vikash7485 wants to merge 3 commits into
Open
fix(web): replace .map() with .forEach() in formalizePoliciesList#7149vikash7485 wants to merge 3 commits into
vikash7485 wants to merge 3 commits into
Conversation
vikash7485
requested review from
Warashi,
ffjlabo,
hongky-1994 and
khanhtc1202
August 11, 2026 03:58
.map() was used at 4 locations in formalizePoliciesList purely for side effects (.push() into outer arrays). Each .map() call silently creates and discards an intermediate array of undefined values, wasting memory. Using .forEach() is semantically correct. Related: pipe-cd#6706 Signed-off-by: vikash7485 <vikkiraj073@gmail.com>
vikash7485
force-pushed
the
fix/formalize-policies-map-to-foreach
branch
from
August 11, 2026 04:01
c9a4c19 to
8d197e7
Compare
rahulshendre
left a comment
rahulshendre
left a comment
Contributor
There was a problem hiding this comment.
nice catch @vikash7485
btw what are your thoughts on using map().join() here 👀
✅ Deploy Preview for pipecd-site canceled.
|
Contributor
Author
|
@rahulshendre I think using I'd be happy to refactor it to a fully declarative |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Replace 4 misused
.map()calls with.forEach()informalizePoliciesList(web/src/utils/formalize-policies-list.ts).Why we need it:
.map()was used at 4 locations purely for side effects (.push()into outer arrays). Each.map()call silently creates and discards an intermediate[undefined, undefined, ...]array, wasting memory. Using.forEach()is semantically correct and avoids the unnecessary allocation.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
No. This is a semantic code correctness fix with no behavioral change.