Skip to content

fix(UT): pin validator clock in tests to avoid fixture cert expiry #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mridulgain merged 3 commits into from
Aug 19, 2026
Merged

fix(UT): pin validator clock in tests to avoid fixture cert expiry #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47c54e5
fix(saml): pin validator clock in tests to avoid fixture cert expiry
mridulgain Aug 18, 2026
7c1f391
Merge branch 'master' into mg/fix-saml-test-cert-expiry
mridulgain Aug 19, 2026
4280625
fix(storage/kubernetes): fix Client name shadowing regression from li…
mridulgain Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions connector/saml/saml_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,9 @@ func runVerify(t *testing.T, ca string, resp string, shouldSucceed bool) {
s := certStore{[]*x509.Certificate{cert}}

validator := dsig.NewDefaultValidationContext(s)
// Pin the validator's clock so signature checks don't fail once the
// fixture certs in testdata/ eventually expire in real time.
validator.Clock = dsig.NewFakeClockAt(time.Date(2020, 1, 1, 0, 0, 0, 0, time.UTC))

data, err := os.ReadFile(resp)
if err != nil {
Expand Down
4 changes: 2 additions & 2 deletions storage/kubernetes/storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ func (cli *client) DeleteClient(ctx context.Context, id string) error {
if err != nil {
return err
}
return cli.delete(resourceClient, c.Name)
return cli.delete(resourceClient, c.ObjectMeta.Name)
}

func (cli *client) DeleteRefresh(ctx context.Context, id string) error {
Expand Down Expand Up @@ -493,7 +493,7 @@ func (cli *client) UpdateClient(ctx context.Context, id string, updater func(old

newClient := cli.fromStorageClient(updated)
newClient.ObjectMeta = c.ObjectMeta
return cli.put(resourceClient, c.Name, newClient)
return cli.put(resourceClient, c.ObjectMeta.Name, newClient)
}

func (cli *client) UpdatePassword(ctx context.Context, email string, updater func(old storage.Password) (storage.Password, error)) error {
Expand Down
Loading