Avoid RowBinary array decoder stack expansion - #432
Draft
ruslandoga wants to merge 1 commit into
Draft
Conversation
Collaborator
Author
|
@coderabbitai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #426.
RowBinary array decoding now keeps the active element type stable and decrements a count, replacing length-proportional type-stack expansion with compact continuation frames that also handle nested Nullable, Tuple, Map, Variant, and Dynamic values.
A complete UInt8 fast path and the counted generic path improve large, chunked, and nested array decoding; a one-million-element prefix now retains 19 words instead of 2,000,009.
Tests cover legacy continuations, varint boundaries, bytewise structured arrays, and constant state size, and
mix test --include slowpasses all 670 executed tests.