ios_publish and spm_publish with release notes#114
Draft
KVSRoyal wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when a release is made with
ios_publishorspm_publish, it's just a raw tag with no release notes, e.g. playerui-swift-package/player 0.15.4. Users expect to see release notes.We should not expect users to know how our funky publishing works (i.e. that they can actually find the release notes in player-ui/player, which is the source repo). So this PR makes
publishcreate actual releases for stable versions, and those releases have actual release notes now. The release notes mirror the source release notes AND have a note linking to the source repo for transparency.