Skip to content

Cleanup - #1550

Open
aleksandy wants to merge 16 commits into
playframework:masterfrom
aleksandy:cleanup
Open

Cleanup#1550
aleksandy wants to merge 16 commits into
playframework:masterfrom
aleksandy:cleanup

Conversation

@aleksandy

Copy link
Copy Markdown
Contributor
  • use toAray(IntFunction) instead of toArray(T[])
  • optimize JavaExtensions#remove()
  • simplify JavaExtensions#pad()
  • simplify JavaExtensions#join()
  • use primitives instead of wrappers
  • use pattern matching instead of explicit cast
  • use String.valueOf() and toString() for the objects stringification instead of concatenation with empty string

@aleksandy

Copy link
Copy Markdown
Contributor Author

@xael-fry, @asolntsev, could you review my PR?

@xael-fry
xael-fry self-requested a review January 22, 2026 08:52
Comment thread framework/src/play/db/jpa/JPQL.java Outdated

@xael-fry xael-fry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MR is so called "cleanup" but it contains refactors,, fixes and all all parts off the code and not on a given part.
Please split your work in different MR, you can also use the conventional commit to have better description of the scope of the modification apply to.

Thanks

@aleksandy

Copy link
Copy Markdown
Contributor Author

I've updated the PR. Removed the replacement of Stack with Deque. The rest of the changes, in my opinion, are quite suitable for a cleanup. Old unused code was removed, some was rewritten using modern capabilities of the standard library and the language.

@aleksandy
aleksandy requested a review from xael-fry February 2, 2026 18:57
@aleksandy

Copy link
Copy Markdown
Contributor Author

@xael-fry, any news about PR?

@aleksandy

Copy link
Copy Markdown
Contributor Author

@xael-fry, do you still have any comments on this PR? Could you merge it?

@mergify

mergify Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@aleksandy

Copy link
Copy Markdown
Contributor Author

Conflicts are fixed. The branch is actualized up to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants