feat: add number_of_employees field to Profile API#320
Draft
Jai Shankar (jaishankar-plivo) wants to merge 1 commit into
Draft
feat: add number_of_employees field to Profile API#320Jai Shankar (jaishankar-plivo) wants to merge 1 commit into
Jai Shankar (jaishankar-plivo) wants to merge 1 commit into
Conversation
Mirrors the campaign-service backend change adding number_of_employees as an optional string to the Profile create & update requests. Added in the same places and style as the recently added doing_business_as (DBA) field: field, builder/creator method, response getter, tests, and fixture. No client-side enum validation; allowed values are documented in comments and validated server-side. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new optional
number_of_employeesfield to the Profile (10DLC/A2P account profile) create & update APIs, mirroring the corresponding campaign-service backend change.Implemented in exactly the same places and style as the recently added
doing_business_as(DBA) field:ProfileAdder— field + constructor param + accessor (creator overload added inProfile.java)ProfileUpdater— field + builder method + getterProfileResponse— field + getterProfileTest— create/get/update coverageprofileGetResponse.jsonfixtureDetails
number_of_employees(JavanumberOfEmployees, serialized via the existing snake_case naming policy — no explicit annotation, matching DBA).String, no client-side enum validation (server validates).BETWEEN_1_AND_10,BETWEEN_11_AND_50,BETWEEN_51_AND_200,BETWEEN_201_AND_500,BETWEEN_501_AND_2000,BETWEEN_2001_AND_10000,MORE_THAN_10001.pom.xml,version.txt) and CHANGELOG entry added, matching the DBA release pattern.🤖 Generated with Claude Code