Replace passage buttons with a full-page visual editor - #13
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readers currently have to choose a paragraph using repeated buttons and cannot edit tables or propose larger changes. Replace that flow with a quiet “Edit this page” link and a dedicated Milkdown editor for the complete page body. Readers can edit sections, lists, links, inline code, and tables, review highlighted changes, recover local drafts, and submit without an account.
The existing Cloudflare/D1/GitHub App pipeline now accepts full-page proposals. The server keeps frontmatter immutable and validates Markdown independently. Unchanged source blocks are preserved verbatim; changed blocks may be normalized. A stale draft branches from its original verified commit so GitHub exposes conflicts instead of overwriting newer content. Legacy passage submissions remain supported.
Milkdown 7.22.1 is pinned. Narrow adapters handle empty table-cell placeholders and provide accessible keyboard toolbar controls. One existing
<parameter>placeholder is formatted as inline code so it no longer parses as HTML. Editor assets are loaded only on editing routes; release builds omit those routes and frozen archives remain unchanged. The editor's main lazy chunk is approximately 173 KB gzip.Validation:
Deployment: the compatible Worker update is deployed separately before this UI is merged. The public interface changes after merge and Pages deployment. A live full-page submission through production Turnstile remains a post-merge launch check. Safari, native mobile keyboards, and unaided-reader usability are not yet verified.