feat(table): support embeddable question types inside table columns - #44
Open
alisher372 wants to merge 1 commit into
Open
feat(table): support embeddable question types inside table columns#44alisher372 wants to merge 1 commit into
alisher372 wants to merge 1 commit into
Conversation
## Summary Add support for question types implementing the new embeddable interface inside table question columns. Instead of knowing about specific plugins, the table question now delegates rendering to any question type implementing the interface. ## What is implemented - support for embeddable question types; - dynamic configuration loading; - embedded administration rendering; - embedded end-user rendering; - server-side rendering for table rows; - validation and preparation of embedded question extra data. ## Motivation The table question previously only supported built-in question types. With this change, any question type implementing the embeddable interface can be used inside a table without adding plugin-specific logic to Advanced Forms. This keeps Advanced Forms independent from external plugins. ## Backward compatibility Existing built-in question types continue to work exactly as before. Plugins not implementing the new interface are unaffected. ## Related Depends on: - GLPI Core PR: <link> Example implementation: - Fields PR: <link>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for question types implementing the new embeddable interface inside table question columns.
Instead of knowing about specific plugins, the table question now delegates rendering to any question type implementing the interface.
What is implemented
Motivation
The table question previously only supported built-in question types.
With this change, any question type implementing the embeddable interface can be used inside a table without adding plugin-specific logic to Advanced Forms.
This keeps Advanced Forms independent from external plugins.
Backward compatibility
Existing built-in question types continue to work exactly as before.
Plugins not implementing the new interface are unaffected.
Related
Depends on:
Example implementation: