[Rom1-B]

Checklist before requesting a review

Please delete options that are not relevant.

• I have performed a self-review of my code.
• I have added tests (when available) that prove my fix is effective or that my feature works.
• I have updated the CHANGELOG with a short functional description of the fix or new feature.
• This change requires a documentation update.

Description

• It fixes !45901
• Backport of Feat: rename oversized containers from their edit form #1248 to GLPI 11.
• When a container's computed table name exceeds MySQL's 64-character limit, the plugin now disables it instead of crashing, and shows a rename form directly on the container's edit page.
• Submitting a shorter name renames the container and reactivates it; if a table with matching data already exists under that name (e.g. after a version migration), its data is preserved instead of being replaced by an empty table.
• plugins:fields:check_database now also reports container/item type pairs with no matching table, and tables with no matching container/item type pair.

Screenshots (if appropriate):

[MyvTsv]

Could you please apply this review?

#1248 (comment)

[Mary-Clb]

When the old or orphan table exists but is empty, it is dropped and recreated through self::create(), whose install() only creates the base columns, so the container's existing fields lose their columns. Saving a value afterwards silently stores nothing. Maybe it would be better to rename the empty table instead of dropping it, like when it contains data.

[Rom1-B]

Good catch, the table is now renamed even when empty, with a test. Same fix applied to #1248.