feat: Add Pulumi support in Stacks IaC management and update docs - #611
Conversation
There was a problem hiding this comment.
✅ Deploy preview for docs-pr-611 is ready!
| Name | Details |
|---|---|
| ⚡ Service | docs-pr-611 (5 / 5 ready) |
| ☁️ Cluster | plural (eks) |
| f438017 | |
| https://console.mgmt.plural.sh/cd/clusters/446acdef-8524-425a-a49f-5336a... | |
| 🔍 Logs URL | https://console.mgmt.plural.sh/cd/clusters/446acdef-8524-425a-a49f-5336a... |
| 🌊 Flow URL | https://console.mgmt.plural.sh/flows/08a17af1-8578-449e-9ae1-28ccd97eafc... |
| Preview Link | Preview |
You can learn more about preview environments and Plural Flows here
Greptile SummaryThis PR adds first-class Pulumi documentation to the Stacks IaC management section, covering backend configuration (Pulumi Cloud and S3/self-managed), secret handling, workload identity, and local execution.
Confidence Score: 4/5Safe to merge; changes are purely documentation additions with no runtime code impact. The new Pulumi page is technically accurate and the YAML examples match the InfrastructureStack CRD spec. The only things worth a second look are the sidebar ordering (Pulumi setup page sits after the more advanced customize-runners page) and a missing trailing newline in local-execution.md — both cosmetic. src/routing/docs-structure.ts — nav ordering places the new Pulumi setup page after the advanced runner-customization page.
|
| Filename | Overview |
|---|---|
| pages/plural-features/stacks-iac-management/pulumi.md | New page documenting Pulumi stack setup; YAML examples are correct for the InfrastructureStack CRD; security guidance is sound |
| pages/plural-features/stacks-iac-management/local-execution.md | Adds a 'Run Pulumi locally' section with accurate S3 backend instructions; missing trailing newline at end of file |
| pages/plural-features/stacks-iac-management/index.md | Adds supported-stack-types table and Pulumi doclink; prose cleanup is accurate |
| src/routing/docs-structure.ts | Inserts pulumi page into nav after customize-runners; ordering could be improved so the setup page precedes the advanced runner-customization page |
| generated/routes.json | Adds route entry for /plural-features/stacks-iac-management/pulumi; unrelated lastmod timestamp bumps are benign |
Reviews (1): Last reviewed commit: "add Pulumi support in Stacks IaC managem..." | Re-trigger Greptile
| { path: 'customize-runners', title: 'Customize stack runners' }, | ||
| { path: 'pulumi', title: 'Pulumi stacks' }, |
There was a problem hiding this comment.
Navigation order puts advanced topic before setup page
customize-runners appears immediately before pulumi in the sidebar. The Pulumi stacks page itself links readers to customize-runners for workload identity setup, making it a follow-on reference — so new users browsing the sidebar top-to-bottom would reach the advanced runner-customization page before discovering how to create a Pulumi stack at all. Moving pulumi to appear before customize-runners would match the natural progression from "create a stack" to "tune how it runs."
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| pulumi stack select dev | ||
| ``` | ||
|
|
||
| Use the same passphrase that was used when the stack was created. See {% doclink to="plural_features_stacks_iac_management_pulumi" %}Pulumi stacks{% /doclink %} for backend and authentication configuration. No newline at end of file |
There was a problem hiding this comment.
File is missing a trailing newline. Most editors and git tools expect a final newline at the end of text files; its absence can cause noisy diffs in future edits.
| Use the same passphrase that was used when the stack was created. See {% doclink to="plural_features_stacks_iac_management_pulumi" %}Pulumi stacks{% /doclink %} for backend and authentication configuration. | |
| Use the same passphrase that was used when the stack was created. See {% doclink to="plural_features_stacks_iac_management_pulumi" %}Pulumi stacks{% /doclink %} for backend and authentication configuration. |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
b7a0566 to
f438017
Compare
Plural Flow: docs
Plural Preview: docs