Skip to content

chore: align CLI CI with patched Go 1.26.5 toolchain #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plural-copilot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: align CLI CI with patched Go 1.26.5 toolchain #784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- uses: actions/setup-go@v4.1.0
- uses: actions/setup-go@v5
with:
go-version-file: go.mod
- uses: github/codeql-action/init@v2
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
chmod +x ${{ env.AWS_NUKE_PATH }}
aws-nuke version
- name: Setup Go
uses: actions/setup-go@v4.1.0
uses: actions/setup-go@v5
with:
go-version-file: go.mod
- name: Add GOBIN to PATH
Expand Down Expand Up @@ -163,7 +163,7 @@ jobs:
with:
version: '>= 363.0.0'
- name: Setup Go
uses: actions/setup-go@v4.1.0
uses: actions/setup-go@v5
with:
go-version-file: go.mod
- name: Add GOBIN to PATH
Expand Down Expand Up @@ -252,7 +252,7 @@ jobs:
eval "$(ssh-agent -s)"
ssh-add ${{ env.VENOM_VAR_gitRepoPrivateKeyPath }}
- name: Setup Go
uses: actions/setup-go@v4.1.0
uses: actions/setup-go@v5
with:
go-version-file: go.mod
- name: Add GOBIN to PATH
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/goreleaser-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
- uses: actions/setup-go@v4.1.0
- uses: actions/setup-go@v5
with:
go-version-file: go.mod
Comment on lines +24 to 26

@greptile-apps greptile-apps Bot Jul 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Action version doesn't drive toolchain selection here

The PR description frames this upgrade as CVE remediation, but actions/setup-go@v4.1.0 with go-version-file: go.mod already resolved and installed Go 1.26.5 (the version declared in go.mod). The action version (v4 vs v5) controls the action's own behaviour (caching defaults, toolchain directive support, etc.), not which Go SDK is downloaded — the go-version-file directive does that. Aligning to v5 is still a good maintenance step (consistent with ci.yaml and edge.yaml, and v5 adds improved module-cache handling), but it doesn't independently address the cited CVEs; those are already remediated by the go 1.26.5 pin in go.mod that was in place before this PR.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!


Expand Down
Loading