ci: decide publish from git (HEAD^), not an npm lookup the repo can't authenticate - #21
Merged
Merged
Conversation
… authenticate @pncit/node-quickbooks is access: restricted and the repo has no NPM_TOKEN, so the #20 guard's unauthenticated npm view saw 404 for the current version, reported it unpublished, and the publish step hit the same E403 (run 33715159834). Compare package.json to HEAD^ instead — the rule the private libraries already use — and always attempt on a manual dispatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #20, which didn't work:
@pncit/node-quickbooksisaccess: restrictedand this repo has noNPM_TOKENsecret, so the unauthenticatednpm viewsaw 404, reported the version unpublished, andnpm publishhit the same E403 (run 33715159834).Replaces the lookup with the rule the private libraries use on the publish side: compare
package.jsontoHEAD^(the checkout is alreadyfetch-depth: 2), skip when unchanged. Aworkflow_dispatchalways attempts the publish. No secret needed.Workflow-only; no version bump. Part of pncit/.github#26.