ci: Node and npm from org variables on both legs (shared-actions v3.0.0) - #22
Merged
Merged
Conversation
The workflows pass vars.NODE_VERSION / vars.NPM_VERSION to
validate-codebase, validate-build and deploy, and every Dockerfile takes
them as build args: `FROM node:${NODE_VERSION}-…` and
`npm i -g "npm@${NPM_VERSION}"` in each stage that runs `npm ci`. No
version literal remains in this repo — .nvmrc is gone, and so is the
top-level verify-node-toolchain step (it asserted the runner's system
node/npm, which nothing uses).
Why: CI has pinned npm 12.0.2 since shared-actions v2.2.0, but images
were built on node:24-bookworm's bundled npm 11. The tested tree and the
shipped image disagreed on the dimension that caused the allowScripts
incident. One org variable now moves both. pncit/.github#23
robgilbreath
force-pushed
the
ci/toolchain-from-org-vars
branch
from
September 3, 2026 17:50
8ccb7f0 to
c2afd3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of pncit/.github#23 — shared-actions v3.0.0 (pncit/shared-actions#34).
What changes
${{ vars.NODE_VERSION }}/${{ vars.NPM_VERSION }}(org Actions variables, currently24.20.0/12.0.2) tovalidate-codebase,validate-buildanddeploy; a repo variable of the same name overrides the org one (canary).ARG NODE_VERSION→FROM node:${NODE_VERSION}-…, and every stage that runsnpm cidoesnpm i -g "npm@${NPM_VERSION}"first. No defaults — deploy/validate-build always pass them..nvmrcdeleted; theverify-node-toolchainstep is gone (it readNODE_MAJOR_VERSION/NPM_MAJOR_VERSION, which no longer exist — that's why this repo's PR checks are currently red).v3.0.0(8bc187e).Why
CI has pinned npm 12.0.2 since shared-actions v2.2.0, but images were built with
node:24-bookworm's bundled npm 11. The tested tree and the shipped image disagreed on exactly the dimension behind the allowScripts incident. Now one org variable moves both legs, and a Node/npm bump is a variable edit, not a 20-repo sweep.Effect of merging
.nvmrcand.github/**are exempt from the bump gate).