fix(bridge): reject adversarialResilience >= validatorCount - #241
Open
crazywriter1 wants to merge 1 commit into
Open
fix(bridge): reject adversarialResilience >= validatorCount#241crazywriter1 wants to merge 1 commit into
crazywriter1 wants to merge 1 commit into
Conversation
f == n (or n == 0) made certificate claims succeed with empty signatures. Require f < n and reject zero required weight at claim time.
Author
|
Hi @abresas @poszu friendly ping for a review when you have a moment. This PR enforces I verified locally with:
Happy to adjust anything if you’d prefer a different validation approach. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adversarialResilience < validatorCountwhen updating the validator set, so certificate claims always require weight ≥ 1requiredWeight == 0(defense-in-depth for misconfigured state)f < ninvariantPreviously
f == n(orn == 0) was accepted by config validation. That madevalidatorCount - adversarialResilience == 0, so an empty aggregate signature (weight = 0) satisfied the claim check. This is an admin misconfiguration footgun, not a default-deployment drain path — shipped configs usef < n— but the contract allowed the bad state and should not.Test plan
forge test --match-contract BridgeUpdateValidatorSetTest -vvforge test --match-path test/Bridge.t.sol