fix a policy annotation syntax example - #2352
Merged
Merged
Conversation
All the k8s object annotation values need to be strings, so we have to quote 'true' so it doesn't parse as a boolean. I searched for other cases where we had an 'ingress.pomerium.io/' annotation with an unquoted 'true' but didn't find any.
✅ Deploy Preview for pomerium-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Greptile SummaryCorrects the Kubernetes Ingress annotation example so its boolean-like value is represented as the required YAML string.
Confidence Score: 5/5The PR appears safe to merge. The changed value is valid YAML string syntax for a Kubernetes annotation and is consistent with the repository’s canonical Ingress examples and templates.
|
| Filename | Overview |
|---|---|
| content/docs/reference/routes/allow-any-authenticated-user.mdx | Updates the annotation example to valid Kubernetes string-map syntax without introducing documentation or behavior issues. |
Reviews (1): Last reviewed commit: "fix a policy annotation syntax example" | Re-trigger Greptile
nickytonline
approved these changes
Aug 25, 2026
calebdoxsey
approved these changes
Aug 25, 2026
kenjenkins
added a commit
that referenced
this pull request
Aug 25, 2026
fix a policy annotation syntax example (#2352) All the k8s object annotation values need to be strings, so we have to quote 'true' so it doesn't parse as a boolean. Co-authored-by: Kenneth Jenkins <51246568+kenjenkins@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All the k8s object annotation values need to be strings, so we have to quote
'true'so it doesn't parse as a boolean.I searched for other cases where we had an
ingress.pomerium.io/annotation with an unquotedtruebut didn't find any.Related
AI disclosure
none
Checklist